Skip to content

Roll back fast-mode evaluation marks from failed conditionals#928

Merged
jviotti merged 1 commit into
mainfrom
fix-logical-condition-inline-cursors
Jul 19, 2026
Merged

Roll back fast-mode evaluation marks from failed conditionals#928
jviotti merged 1 commit into
mainfrom
fix-logical-condition-inline-cursors

Conversation

@jviotti

@jviotti jviotti commented Jul 16, 2026

Copy link
Copy Markdown
Member

No description provided.

@jviotti jviotti changed the title fix logical condition inline cursors Fix LogicalCondition bug on fast mode with annotation whitelists Jul 16, 2026
@jviotti
jviotti force-pushed the fix-logical-condition-inline-cursors branch from feb2f7e to 1c16be7 Compare July 16, 2026 19:05
@jviotti
jviotti marked this pull request as ready for review July 16, 2026 19:05
@augmentcode

augmentcode Bot commented Jul 16, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR fixes a fast-mode tracking issue where evaluation marks from failed conditional/disjunction branches could leak into subsequent validation.

Changes:

  • Adds checkpoint()/rewind() helpers to the JavaScript Blaze evaluator to snapshot and truncate the evaluated-mark stack
  • Adds equivalent Evaluator::checkpoint()/Evaluator::rewind() APIs to the C++ evaluator
  • Updates LogicalOr, LogicalXor, and LogicalCondition (including fast handlers) to rewind evaluated marks when a branch/condition fails while the parent instruction continues
  • Extends evaluator JSON test suites (draft-07, 2019-09, 2020-12) with regression cases covering if/then/else, anyOf, oneOf, and interactions with unevaluatedProperties

Technical Notes: The fix ensures only successful applicator branches contribute evaluated annotations, preventing incorrect behavior in keywords that depend on evaluation tracking (e.g., unevaluatedProperties) when earlier branches fail.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: 3376400 Previous: e29d693 Ratio
Schema_Iterator_ISO_Language 1946864.2633067092 ns/iter 1798273.1010365356 ns/iter 1.08
Schema_Tracker_ISO_Language 3003318.795349197 ns/iter 2725450.3524900293 ns/iter 1.10
Schema_Tracker_ISO_Language_To_JSON 15904403.97825185 ns/iter 14589042.520832151 ns/iter 1.09
Schema_Frame_WoT_References 4877443.819356315 ns/iter 4395642.3571428 ns/iter 1.11
Schema_Frame_OMC_References 22957910.931021117 ns/iter 18706032.67567534 ns/iter 1.23
Schema_Frame_OMC_Locations 19025052.918919217 ns/iter 17123175.82926949 ns/iter 1.11
Schema_Frame_ISO_Language_Locations 75322490.66672295 ns/iter 67670258.29999511 ns/iter 1.11
Schema_Frame_KrakenD_References 39966372.52941368 ns/iter 35374908.349996306 ns/iter 1.13
Schema_Frame_KrakenD_Reachable 348687000.0001545 ns/iter 344417250.00004905 ns/iter 1.01
Schema_Frame_ISO_Language_Locations_To_JSON 74680333.25005762 ns/iter 71956963.6250128 ns/iter 1.04
Schema_Frame_Many_Resources_References 266347770.99980056 ns/iter 260093013.999987 ns/iter 1.02
Schema_Bundle_Meta_2020_12 1236888.3675711963 ns/iter 1275071.1231272365 ns/iter 0.97
Schema_Format_ISO_Language_To_JSON 76739578.88891892 ns/iter 78784531.37499264 ns/iter 0.97
E2E_Compiler_adaptivecard 52147041.66663372 ns/iter 48936733.999994434 ns/iter 1.07
E2E_Compiler_ansible_meta 23138528.624997433 ns/iter 27316475.80645263 ns/iter 0.85
E2E_Compiler_aws_cdk 297353.0294759676 ns/iter 275418.4467065754 ns/iter 1.08
E2E_Compiler_babelrc 2010024.0748499215 ns/iter 1897347.2231182093 ns/iter 1.06
E2E_Compiler_clang_format 15618725.82000433 ns/iter 16503096.96153858 ns/iter 0.95
E2E_Compiler_cmake_presets 24107458.321428306 ns/iter 21311723.484845143 ns/iter 1.13
E2E_Compiler_code_climate 2089736.4123084117 ns/iter 2001862.4569893389 ns/iter 1.04
E2E_Compiler_cql2 12886550.920628661 ns/iter 10077245.967740892 ns/iter 1.28
E2E_Compiler_cspell 19988995.833349086 ns/iter 17841842.948716756 ns/iter 1.12
E2E_Compiler_cypress 3321471.5639807493 ns/iter 3112172.222222398 ns/iter 1.07
E2E_Compiler_deno 6275403.531527355 ns/iter 5716337.398373839 ns/iter 1.10
E2E_Compiler_dependabot 3260435.9392484454 ns/iter 2991433.0779220737 ns/iter 1.09
E2E_Compiler_draft_04 1907235.2271472071 ns/iter 1757331.7700001213 ns/iter 1.09
E2E_Compiler_fabric_mod 3521742.445599477 ns/iter 3322289.461538529 ns/iter 1.06
E2E_Compiler_geojson 22102244.612905186 ns/iter 17554123.950000644 ns/iter 1.26
E2E_Compiler_gitpod_configuration 3788360.5054315445 ns/iter 5932116.995073857 ns/iter 0.64
E2E_Compiler_helm_chart_lock 480851.83228972193 ns/iter 538511.6657736509 ns/iter 0.89
E2E_Compiler_importmap 194596.6457223187 ns/iter 203813.18074769655 ns/iter 0.95
E2E_Compiler_jasmine 992024.5409601728 ns/iter 1116294.2413793174 ns/iter 0.89
E2E_Compiler_jshintrc 3080870.986237525 ns/iter 3409095.180094594 ns/iter 0.90
E2E_Compiler_jsconfig 17510978.07894104 ns/iter 21018689.102564353 ns/iter 0.83
E2E_Compiler_krakend 129167016.80005643 ns/iter 129400416.79999013 ns/iter 1.00
E2E_Compiler_lazygit 30418132.260899216 ns/iter 33367687.499999 ns/iter 0.91
E2E_Compiler_lerna 1198671.0176981143 ns/iter 1463153.49414514 ns/iter 0.82
E2E_Compiler_nest_cli 5886135.245765542 ns/iter 5960817.073170757 ns/iter 0.99
E2E_Compiler_omc 159643324.99988812 ns/iter 157757466.59999186 ns/iter 1.01
E2E_Compiler_omnisharp 6081566.9487180235 ns/iter 6305050.341666174 ns/iter 0.96
E2E_Compiler_openapi 23082496.21210328 ns/iter 24784932.77419602 ns/iter 0.93
E2E_Compiler_pre_commit_hooks 4005659.9248553514 ns/iter 5098386.789473794 ns/iter 0.79
E2E_Compiler_pulumi 3027295.32636115 ns/iter 3317505.376343732 ns/iter 0.91
E2E_Compiler_semantic_release 1196860.9775629912 ns/iter 1225944.7725118964 ns/iter 0.98
E2E_Compiler_stale 1134636.710784274 ns/iter 1234375.6495327658 ns/iter 0.92
E2E_Compiler_stylecop 4887189.748201276 ns/iter 5955884.5799995195 ns/iter 0.82
E2E_Compiler_tmuxinator 1388913.7258065748 ns/iter 1554115.5750528402 ns/iter 0.89
E2E_Compiler_ui5 46970949.99998323 ns/iter 59751345.89999697 ns/iter 0.79
E2E_Compiler_ui5_manifest 290187332.9997215 ns/iter 327917124.99999905 ns/iter 0.88
E2E_Compiler_unreal_engine_uproject 3735058.6098909844 ns/iter 3984124.15228424 ns/iter 0.94
E2E_Compiler_users_array 779433.8870164978 ns/iter 707511.70588237 ns/iter 1.10
E2E_Compiler_vercel 12001309.895841435 ns/iter 9967648.47887392 ns/iter 1.20
E2E_Compiler_yamllint 247485.9805238476 ns/iter 219161.04787233047 ns/iter 1.13
E2E_Evaluator_adaptivecard 18501.298468974263 ns/iter 18834.930415569008 ns/iter 0.98
E2E_Evaluator_ansible_meta 170636.0870087204 ns/iter 155916.69447525227 ns/iter 1.09
E2E_Evaluator_aws_cdk 35817.916057646726 ns/iter 34233.6050664863 ns/iter 1.05
E2E_Evaluator_babelrc 82300.05018097542 ns/iter 79746.47428636352 ns/iter 1.03
E2E_Evaluator_cerebrum_criminal_case 698232.4473421883 ns/iter 641964.3841912195 ns/iter 1.09
E2E_Evaluator_clang_format 94909.12046531514 ns/iter 88892.95643986914 ns/iter 1.07
E2E_Evaluator_cmake_presets 3198089.2857143367 ns/iter 2966012.7241375563 ns/iter 1.08
E2E_Evaluator_code_climate 124872.54023622414 ns/iter 117662.57020202882 ns/iter 1.06
E2E_Evaluator_cql2 143315.46281996096 ns/iter 134274.515145443 ns/iter 1.07
E2E_Evaluator_cspell 427714.6985195953 ns/iter 390012.6326075013 ns/iter 1.10
E2E_Evaluator_cypress 139814.98076140918 ns/iter 129707.9705337306 ns/iter 1.08
E2E_Evaluator_deno 226611.73112296136 ns/iter 229777.96056337652 ns/iter 0.99
E2E_Evaluator_dependabot 250058.61360446998 ns/iter 224303.01463569232 ns/iter 1.11
E2E_Evaluator_draft_04 5535061.567163428 ns/iter 4779293.358107888 ns/iter 1.16
E2E_Evaluator_fabric_mod 467157.1325137887 ns/iter 465698.54797982686 ns/iter 1.00
E2E_Evaluator_geojson 8583700.301203927 ns/iter 8714740.425288016 ns/iter 0.98
E2E_Evaluator_gitpod_configuration 169528.59385674566 ns/iter 157528.4656061014 ns/iter 1.08
E2E_Evaluator_helm_chart_lock 238992.58438461684 ns/iter 214699.1284034823 ns/iter 1.11
E2E_Evaluator_importmap 38395.04094553428 ns/iter 32851.19807928552 ns/iter 1.17
E2E_Evaluator_jasmine 88843.64433318425 ns/iter 78884.66177466529 ns/iter 1.13
E2E_Evaluator_jshintrc 935747.8217153505 ns/iter 879375.4078143972 ns/iter 1.06
E2E_Evaluator_jsconfig 305345.9634842134 ns/iter 292544.1636851194 ns/iter 1.04
E2E_Evaluator_krakend 131830.75304945034 ns/iter 122144.05060622194 ns/iter 1.08
E2E_Evaluator_lazygit 96715.27229677183 ns/iter 85308.80647161187 ns/iter 1.13
E2E_Evaluator_lerna 116768.85531840056 ns/iter 111065.99984123051 ns/iter 1.05
E2E_Evaluator_nest_cli 130058.10998367965 ns/iter 123615.19491377767 ns/iter 1.05
E2E_Evaluator_omc 15179.847324127275 ns/iter 13902.40989688218 ns/iter 1.09
E2E_Evaluator_omnisharp 433395.94928883144 ns/iter 398116.1055936172 ns/iter 1.09
E2E_Evaluator_openapi 8353872.728261906 ns/iter 6892682.142857406 ns/iter 1.21
E2E_Evaluator_pre_commit_hooks 342266.2835250525 ns/iter 342525.26231815224 ns/iter 1.00
E2E_Evaluator_pulumi 507623.7679228077 ns/iter 569505.7692307378 ns/iter 0.89
E2E_Evaluator_semantic_release 72003.22782571407 ns/iter 71079.80829945546 ns/iter 1.01
E2E_Evaluator_stale 119522.64555318945 ns/iter 109276.76613408195 ns/iter 1.09
E2E_Evaluator_stylecop 191069.11488809306 ns/iter 200155.58680552413 ns/iter 0.95
E2E_Evaluator_tmuxinator 67463.52441668672 ns/iter 63577.82509746293 ns/iter 1.06
E2E_Evaluator_ui5 348283.0445546365 ns/iter 340243.08139536047 ns/iter 1.02
E2E_Evaluator_ui5_manifest 1599178.6390813282 ns/iter 1438738.6434426394 ns/iter 1.11
E2E_Evaluator_unreal_engine_uproject 329096.25059908966 ns/iter 311025.20026698674 ns/iter 1.06
E2E_Evaluator_users_array 488165.0353011459 ns/iter 417980.66428995394 ns/iter 1.17
E2E_Evaluator_vercel 226849.58810156072 ns/iter 212410.83573573365 ns/iter 1.07
E2E_Evaluator_yamllint 6628.461715566642 ns/iter 6296.164604897672 ns/iter 1.05
JSONLD_Catalog 18462094.31579681 ns/iter 16533995.926828893 ns/iter 1.12
Micro_Draft4_Meta_1_No_Callback 132.12671093288225 ns/iter 128.29965746156097 ns/iter 1.03
Micro_Draft4_Required_Properties 681.9123097025908 ns/iter 678.4992455384726 ns/iter 1.01
Micro_Draft4_Many_Optional_Properties_Minimal_Match 16.107347145567005 ns/iter 16.88264111013445 ns/iter 0.95
Micro_Draft4_Few_Optional_Properties_Minimal_Match 7.868446849952725 ns/iter 8.064246914603824 ns/iter 0.98
Micro_Draft4_Items_Schema 209.7124891961459 ns/iter 208.38013667470102 ns/iter 1.01
Micro_Draft4_Nested_Object 1.0049820597066899 ns/iter 0.9619139417932687 ns/iter 1.04
Micro_Draft4_Properties_Triad_Optional 209.17072225035412 ns/iter 218.02659950460819 ns/iter 0.96
Micro_Draft4_Properties_Triad_Closed 170.18177409185552 ns/iter 159.74475465986487 ns/iter 1.07
Micro_Draft4_Properties_Triad_Required 223.94333820084927 ns/iter 209.90281059190517 ns/iter 1.07
Micro_Draft4_Properties_Closed 41.1750535110331 ns/iter 38.78494450995063 ns/iter 1.06
Micro_Draft4_Non_Recursive_Ref 12.418276083290861 ns/iter 12.460335451548774 ns/iter 1.00
Micro_Draft4_Pattern_Properties_True 147.97434724844476 ns/iter 135.1352381342019 ns/iter 1.10
Micro_Draft4_Ref_To_Single_Property 7.879136982369475 ns/iter 7.4771280790207655 ns/iter 1.05
Micro_Draft4_Additional_Properties_Type 26.69512964097958 ns/iter 24.626870623919444 ns/iter 1.08
Micro_Draft4_Nested_Oneof 35.26290708460563 ns/iter 37.33921519945747 ns/iter 0.94
Micro_Draft4_Short_Enum 5.059148983820869 ns/iter 5.270627920000379 ns/iter 0.96
Micro_Draft4_Long_Enum 9.747897545145136 ns/iter 10.679812966576986 ns/iter 0.91
Micro_Draft4_Long_Enum_Short_Strings 6.559528499081903 ns/iter 6.839528465278344 ns/iter 0.96
Micro_Draft4_Type_Object 2.4098746688952204 ns/iter 2.3954394766029856 ns/iter 1.01
Micro_Draft4_Ref_Single_100 1766354.8288490342 ns/iter 1629109.8758782654 ns/iter 1.08
Micro_Draft4_Compile_Ref_Many_Nested 1351515.4472782894 ns/iter 1130919.3640775073 ns/iter 1.20
Micro_Draft4_Compile_Wrap 1989076.3665588715 ns/iter 1808884.7205128844 ns/iter 1.10
Micro_Draft6_Property_Names 93.46790970063641 ns/iter 95.2025943031431 ns/iter 0.98
Micro_Draft6_Compile_FHIR 10768759000.0005 ns/iter 9507841458.00003 ns/iter 1.13
Micro_Draft7_If_Then_Else 16.895173430415856 ns/iter 16.036739841284597 ns/iter 1.05
Micro_2019_09_Unevaluated_Properties 26.90097730880341 ns/iter 26.253875634017774 ns/iter 1.02
Micro_2019_09_Compile_Wrap 291588999.9999308 ns/iter 265877791.66663948 ns/iter 1.10
Micro_2020_12_Dynamic_Ref 593.0734906696401 ns/iter 555.1838620895696 ns/iter 1.07
Micro_2020_12_Dynamic_Ref_Single 2.406750481193606 ns/iter 2.2478325729219217 ns/iter 1.07
Micro_2020_12_Simple_Output_Mask 801.6785450181497 ns/iter 755.758363457792 ns/iter 1.06
Micro_2020_12_Simple_Output_Annotations 58847.056261642494 ns/iter 59850.2097522614 ns/iter 0.98
Micro_2020_12_Simple_Output_Annotation_Dropping 1507246.1149680284 ns/iter 1420610.4089069816 ns/iter 1.06
Micro_2020_12_Compile_NonCircular_Shared_Refs 780061.2994354602 ns/iter 720200.9549642546 ns/iter 1.08
Micro_2020_12_Exhaustive_Deep_Numeric 4967.075042908915 ns/iter 4579.133186842454 ns/iter 1.08
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput 35590.51106982837 ns/iter 33256.30296589959 ns/iter 1.07
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput 14250.237970635544 ns/iter 13283.317257961196 ns/iter 1.07
Micro_2020_12_Exhaustive_Deep_Numeric_Fail 85.99919484981291 ns/iter 86.67178770757249 ns/iter 0.99
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput 3247.6252421290815 ns/iter 3032.0649102211833 ns/iter 1.07
Alterschema_Check_Readibility_ISO_Language_Set_3 227433722.33344415 ns/iter 203730833.33330062 ns/iter 1.12
Alterschema_Check_Readibility_OMC 60788223.545469835 ns/iter 55542819.416662805 ns/iter 1.09
Alterschema_Check_Readibility_KrakenD 660990415.9995494 ns/iter 597335082.9999617 ns/iter 1.11
Alterschema_Apply_Readibility_KrakenD 72511989916.99948 ns/iter 65675719291.99994 ns/iter 1.10
Alterschema_Check_Invalid_External_Refs 165914604.2500197 ns/iter 163524281.24997687 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaScript (macos/llvm)

Details
Benchmark suite Current: 3376400 Previous: e29d693 Ratio
E2E_Evaluator_adaptivecard 129695 ns 96203 ns 1.35
E2E_Evaluator_ansible-meta 493415 ns 357274 ns 1.38
E2E_Evaluator_aws-cdk 134811 ns 108414 ns 1.24
E2E_Evaluator_babelrc 312641 ns 257716 ns 1.21
E2E_Evaluator_cerebrum-criminal-case 2377009 ns 1594461 ns 1.49
E2E_Evaluator_clang-format 301822 ns 185005 ns 1.63
E2E_Evaluator_cmake-presets 16132819 ns 10429292 ns 1.55
E2E_Evaluator_code-climate 406351 ns 353743 ns 1.15
E2E_Evaluator_cql2 1076474 ns 916937 ns 1.17
E2E_Evaluator_cspell 1347087 ns 979481 ns 1.38
E2E_Evaluator_cypress 793891 ns 497451 ns 1.60
E2E_Evaluator_deno 929772 ns 602971 ns 1.54
E2E_Evaluator_dependabot 876947 ns 696839 ns 1.26
E2E_Evaluator_draft-04 18538769 ns 13959487 ns 1.33
E2E_Evaluator_fabric-mod 2034299 ns 1271825 ns 1.60
E2E_Evaluator_geojson 20116226 ns 14945323 ns 1.35
E2E_Evaluator_gitpod-configuration 577146 ns 485247 ns 1.19
E2E_Evaluator_helm-chart-lock 952722 ns 825986 ns 1.15
E2E_Evaluator_importmap 309150 ns 194763 ns 1.59
E2E_Evaluator_jasmine 247512 ns 198190 ns 1.25
E2E_Evaluator_jsconfig 1180664 ns 789911 ns 1.49
E2E_Evaluator_jshintrc 2573725 ns 1854931 ns 1.39
E2E_Evaluator_krakend 552075 ns 394530 ns 1.40
E2E_Evaluator_lazygit 385229 ns 273399 ns 1.41
E2E_Evaluator_lerna 376247 ns 300008 ns 1.25
E2E_Evaluator_nest-cli 564320 ns 386054 ns 1.46
E2E_Evaluator_omc 176248 ns 90152 ns 1.96
E2E_Evaluator_omnisharp 1144449 ns 911292 ns 1.26
E2E_Evaluator_openapi 37407733 ns 23395357 ns 1.60
E2E_Evaluator_pre-commit-hooks 1444747 ns 1258527 ns 1.15
E2E_Evaluator_pulumi 1963133 ns 1369506 ns 1.43
E2E_Evaluator_semantic-release 210231 ns 171709 ns 1.22
E2E_Evaluator_stale 297534 ns 259476 ns 1.15
E2E_Evaluator_stylecop 1007410 ns 652432 ns 1.54
E2E_Evaluator_tmuxinator 313074 ns 152001 ns 2.06
E2E_Evaluator_ui5 2115519 ns 1425232 ns 1.48
E2E_Evaluator_ui5-manifest 10994193 ns 6873002 ns 1.60
E2E_Evaluator_unreal-engine-uproject 1432186 ns 1180805 ns 1.21
E2E_Evaluator_users-array 3409368 ns 2154474 ns 1.58
E2E_Evaluator_vercel 1111200 ns 669458 ns 1.66
E2E_Evaluator_yamllint 28942 ns 22383 ns 1.29

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: 3376400 Previous: e29d693 Ratio
Schema_Iterator_ISO_Language 3032264.047826926 ns/iter 2889941.268594709 ns/iter 1.05
Schema_Tracker_ISO_Language 4715418.641892853 ns/iter 4396520.496855333 ns/iter 1.07
Schema_Tracker_ISO_Language_To_JSON 21297856.906251412 ns/iter 21644538.424242675 ns/iter 0.98
Schema_Frame_WoT_References 4520776.193549541 ns/iter 4227855.797545686 ns/iter 1.07
Schema_Frame_OMC_References 21795845.935479693 ns/iter 18995791.59459569 ns/iter 1.15
Schema_Frame_OMC_Locations 19239767.799997155 ns/iter 17326817.225000467 ns/iter 1.11
Schema_Frame_ISO_Language_Locations 106611474.83335753 ns/iter 99925890.00000863 ns/iter 1.07
Schema_Frame_KrakenD_References 39581658.05555483 ns/iter 36996715.00000553 ns/iter 1.07
Schema_Frame_KrakenD_Reachable 546991020.9999398 ns/iter 663956534.0000217 ns/iter 0.82
Schema_Frame_ISO_Language_Locations_To_JSON 121192184.39997895 ns/iter 122049796.60000391 ns/iter 0.99
Schema_Frame_Many_Resources_References 355171989.0000413 ns/iter 348235961.49999505 ns/iter 1.02
Schema_Bundle_Meta_2020_12 1457198.1517707482 ns/iter 1445585.291927173 ns/iter 1.01
Schema_Format_ISO_Language_To_JSON 111028226.833317 ns/iter 104991067.85714827 ns/iter 1.06
E2E_Compiler_adaptivecard 60990408.00000921 ns/iter 58347839.3333318 ns/iter 1.05
E2E_Compiler_ansible_meta 24885260.142850388 ns/iter 22729217.129032746 ns/iter 1.09
E2E_Compiler_aws_cdk 329649.05144998163 ns/iter 304079.41594453726 ns/iter 1.08
E2E_Compiler_babelrc 2308325.794019856 ns/iter 2202405.0846394063 ns/iter 1.05
E2E_Compiler_clang_format 16229674.372092377 ns/iter 15121213.717389744 ns/iter 1.07
E2E_Compiler_cmake_presets 26278651.55555911 ns/iter 24592511.758618426 ns/iter 1.07
E2E_Compiler_code_climate 2297316.019672269 ns/iter 2237055.5591056943 ns/iter 1.03
E2E_Compiler_cql2 12985609.277776616 ns/iter 12478231.599999906 ns/iter 1.04
E2E_Compiler_cspell 23023264.77419111 ns/iter 21775936.06250028 ns/iter 1.06
E2E_Compiler_cypress 3925352.2402228736 ns/iter 3737975.427807433 ns/iter 1.05
E2E_Compiler_deno 6999939.100001029 ns/iter 6532394.34579463 ns/iter 1.07
E2E_Compiler_dependabot 3511805.2613065243 ns/iter 3351986.394366517 ns/iter 1.05
E2E_Compiler_draft_04 2437193.267360903 ns/iter 2371777.0912162913 ns/iter 1.03
E2E_Compiler_fabric_mod 4245998.096970046 ns/iter 4091731.808139864 ns/iter 1.04
E2E_Compiler_geojson 20713162.3235321 ns/iter 19426195.611111376 ns/iter 1.07
E2E_Compiler_gitpod_configuration 4489522.602564368 ns/iter 4300603.809816003 ns/iter 1.04
E2E_Compiler_helm_chart_lock 619159.2497795408 ns/iter 558148.7518014068 ns/iter 1.11
E2E_Compiler_importmap 244546.83791301923 ns/iter 224064.47147438675 ns/iter 1.09
E2E_Compiler_jasmine 1220453.8469564875 ns/iter 1183952.5499153414 ns/iter 1.03
E2E_Compiler_jshintrc 3855928.093406584 ns/iter 3573984.0357144442 ns/iter 1.08
E2E_Compiler_jsconfig 20060482.79999959 ns/iter 18585466.473684605 ns/iter 1.08
E2E_Compiler_krakend 144040210.5999965 ns/iter 130619890.20000055 ns/iter 1.10
E2E_Compiler_lazygit 30407507.56521566 ns/iter 28680082.04166491 ns/iter 1.06
E2E_Compiler_lerna 1429045.3504099601 ns/iter 1371855.1484374064 ns/iter 1.04
E2E_Compiler_nest_cli 6658794.47619123 ns/iter 6279367.234234079 ns/iter 1.06
E2E_Compiler_omc 161207147.49996522 ns/iter 146265929.19998986 ns/iter 1.10
E2E_Compiler_omnisharp 5978085.711865911 ns/iter 5518840.26771669 ns/iter 1.08
E2E_Compiler_openapi 22774995.10000022 ns/iter 21926728.937497586 ns/iter 1.04
E2E_Compiler_pre_commit_hooks 4632267.993377999 ns/iter 4301767.148147935 ns/iter 1.08
E2E_Compiler_pulumi 3591141.379488013 ns/iter 3483905.6783918827 ns/iter 1.03
E2E_Compiler_semantic_release 1364890.6081871742 ns/iter 1351776.5758754222 ns/iter 1.01
E2E_Compiler_stale 1397202.2435130433 ns/iter 1336034.159308906 ns/iter 1.05
E2E_Compiler_stylecop 5191005.301471103 ns/iter 4677886.973153693 ns/iter 1.11
E2E_Compiler_tmuxinator 1680769.9496401285 ns/iter 1621874.463133602 ns/iter 1.04
E2E_Compiler_ui5 49124220.533334054 ns/iter 46133622.00000211 ns/iter 1.06
E2E_Compiler_ui5_manifest 337437094.49993277 ns/iter 300877959.9999798 ns/iter 1.12
E2E_Compiler_unreal_engine_uproject 4099330.684210953 ns/iter 3895336.754190062 ns/iter 1.05
E2E_Compiler_users_array 792803.6502293891 ns/iter 769955.5065934354 ns/iter 1.03
E2E_Compiler_vercel 12138783.964912778 ns/iter 11625605.366666984 ns/iter 1.04
E2E_Compiler_yamllint 305534.15945823793 ns/iter 290295.63861790736 ns/iter 1.05
E2E_Evaluator_adaptivecard 25413.17480904925 ns/iter 21992.256876747284 ns/iter 1.16
E2E_Evaluator_ansible_meta 243383.98595890272 ns/iter 193017.5151348467 ns/iter 1.26
E2E_Evaluator_aws_cdk 52947.17135197523 ns/iter 43175.70567157309 ns/iter 1.23
E2E_Evaluator_babelrc 115983.37610766148 ns/iter 104357.85784974477 ns/iter 1.11
E2E_Evaluator_cerebrum_criminal_case 1103025.4897960993 ns/iter 1021297.0942562615 ns/iter 1.08
E2E_Evaluator_clang_format 118706.22713364934 ns/iter 111892.3649016115 ns/iter 1.06
E2E_Evaluator_cmake_presets 5780818.39999969 ns/iter 4644562.222222769 ns/iter 1.24
E2E_Evaluator_code_climate 189530.81171772227 ns/iter 173564.8601831244 ns/iter 1.09
E2E_Evaluator_cql2 221213.20039229628 ns/iter 173334.40329836312 ns/iter 1.28
E2E_Evaluator_cspell 636858.2655109077 ns/iter 584641.8916877082 ns/iter 1.09
E2E_Evaluator_cypress 194677.23010332184 ns/iter 185139.2227513195 ns/iter 1.05
E2E_Evaluator_deno 323822.70792773 ns/iter 334928.0396235364 ns/iter 0.97
E2E_Evaluator_dependabot 334042.94849783793 ns/iter 316007.40820928675 ns/iter 1.06
E2E_Evaluator_draft_04 10262982.617645964 ns/iter 7561331.182795515 ns/iter 1.36
E2E_Evaluator_fabric_mod 698633.1201628979 ns/iter 684164.1820809862 ns/iter 1.02
E2E_Evaluator_geojson 17503657.524997607 ns/iter 19275751.833330587 ns/iter 0.91
E2E_Evaluator_gitpod_configuration 250674.0035536794 ns/iter 215257.10616232562 ns/iter 1.16
E2E_Evaluator_helm_chart_lock 324095.4203851333 ns/iter 440556.19218651793 ns/iter 0.74
E2E_Evaluator_importmap 52130.303905899345 ns/iter 36364.90497832285 ns/iter 1.43
E2E_Evaluator_jasmine 109362.40143479683 ns/iter 108474.67780539634 ns/iter 1.01
E2E_Evaluator_jshintrc 1208975.699481861 ns/iter 1217592.9721738414 ns/iter 0.99
E2E_Evaluator_jsconfig 435459.1740486372 ns/iter 384041.94777772063 ns/iter 1.13
E2E_Evaluator_krakend 225804.1648665578 ns/iter 165324.06720302688 ns/iter 1.37
E2E_Evaluator_lazygit 154758.27969093216 ns/iter 120102.34210978552 ns/iter 1.29
E2E_Evaluator_lerna 148408.31306929403 ns/iter 155703.2276605129 ns/iter 0.95
E2E_Evaluator_nest_cli 198837.83618031943 ns/iter 175076.58539634454 ns/iter 1.14
E2E_Evaluator_omc 21930.868240500415 ns/iter 17786.779795743616 ns/iter 1.23
E2E_Evaluator_omnisharp 612485.3640352213 ns/iter 555035.6383821644 ns/iter 1.10
E2E_Evaluator_openapi 16333571.523811469 ns/iter 15109742.76923076 ns/iter 1.08
E2E_Evaluator_pre_commit_hooks 507754.0176860227 ns/iter 487623.5601659699 ns/iter 1.04
E2E_Evaluator_pulumi 689206.2485089548 ns/iter 745289.82409385 ns/iter 0.92
E2E_Evaluator_semantic_release 106783.18217820964 ns/iter 84257.71192771416 ns/iter 1.27
E2E_Evaluator_stale 154295.1778781009 ns/iter 141948.47576555773 ns/iter 1.09
E2E_Evaluator_stylecop 303948.3468409164 ns/iter 250208.52857647743 ns/iter 1.21
E2E_Evaluator_tmuxinator 102231.44684580166 ns/iter 90000.14322514896 ns/iter 1.14
E2E_Evaluator_ui5 530256.0685975192 ns/iter 435503.5084216946 ns/iter 1.22
E2E_Evaluator_ui5_manifest 3150624.068965648 ns/iter 2478031.8207882782 ns/iter 1.27
E2E_Evaluator_unreal_engine_uproject 453851.0649518565 ns/iter 433450.08679479914 ns/iter 1.05
E2E_Evaluator_users_array 698540.9114876863 ns/iter 640802.1588613688 ns/iter 1.09
E2E_Evaluator_vercel 328272.5128086163 ns/iter 321733.91531700117 ns/iter 1.02
E2E_Evaluator_yamllint 9109.041566218053 ns/iter 7530.184520308856 ns/iter 1.21
JSONLD_Catalog 27302595.800001655 ns/iter 19742703.171430416 ns/iter 1.38
Micro_Draft4_Meta_1_No_Callback 199.30238027063248 ns/iter 173.8706012797441 ns/iter 1.15
Micro_Draft4_Required_Properties 900.8430104194935 ns/iter 839.2370635462848 ns/iter 1.07
Micro_Draft4_Many_Optional_Properties_Minimal_Match 23.3481207776185 ns/iter 22.342969385172474 ns/iter 1.04
Micro_Draft4_Few_Optional_Properties_Minimal_Match 12.16619874718181 ns/iter 9.73261206744669 ns/iter 1.25
Micro_Draft4_Items_Schema 279.67581192077347 ns/iter 305.1071900254389 ns/iter 0.92
Micro_Draft4_Nested_Object 1.8684452509373142 ns/iter 1.1454803954237105 ns/iter 1.63
Micro_Draft4_Properties_Triad_Optional 330.05536986135934 ns/iter 291.97899204755345 ns/iter 1.13
Micro_Draft4_Properties_Triad_Closed 272.82758954822884 ns/iter 239.54506994613772 ns/iter 1.14
Micro_Draft4_Properties_Triad_Required 355.79024251542864 ns/iter 316.0075645063842 ns/iter 1.13
Micro_Draft4_Properties_Closed 59.50229666483951 ns/iter 53.1830815968476 ns/iter 1.12
Micro_Draft4_Non_Recursive_Ref 14.37655225305852 ns/iter 13.807254850477083 ns/iter 1.04
Micro_Draft4_Pattern_Properties_True 159.56337637626487 ns/iter 144.09336641749 ns/iter 1.11
Micro_Draft4_Ref_To_Single_Property 12.15129205078516 ns/iter 9.741039767984121 ns/iter 1.25
Micro_Draft4_Additional_Properties_Type 33.32383392660922 ns/iter 37.519984244143195 ns/iter 0.89
Micro_Draft4_Nested_Oneof 57.617229951416235 ns/iter 51.65180623945139 ns/iter 1.12
Micro_Draft4_Short_Enum 12.364254042040418 ns/iter 9.772564890178849 ns/iter 1.27
Micro_Draft4_Long_Enum 14.035918911937594 ns/iter 12.839964463348764 ns/iter 1.09
Micro_Draft4_Long_Enum_Short_Strings 12.338877153121594 ns/iter 9.76753486454705 ns/iter 1.26
Micro_Draft4_Type_Object 3.52251058955986 ns/iter 3.019202363565124 ns/iter 1.17
Micro_Draft4_Ref_Single_100 2365385.7676768275 ns/iter 2200132.5772869578 ns/iter 1.08
Micro_Draft4_Compile_Ref_Many_Nested 1713015.4656862102 ns/iter 1651735.6415091993 ns/iter 1.04
Micro_Draft4_Compile_Wrap 2335975.4782610787 ns/iter 2239286.048077014 ns/iter 1.04
Micro_Draft6_Property_Names 118.4116990981696 ns/iter 119.37090181628226 ns/iter 0.99
Micro_Draft6_Compile_FHIR 16789087350.000046 ns/iter 17122822621.000069 ns/iter 0.98
Micro_Draft7_If_Then_Else 22.421704547185247 ns/iter 23.465652414762197 ns/iter 0.96
Micro_2019_09_Unevaluated_Properties 27.678639190492024 ns/iter 28.56230903622143 ns/iter 0.97
Micro_2019_09_Compile_Wrap 321037155.4999938 ns/iter 285961946.499981 ns/iter 1.12
Micro_2020_12_Dynamic_Ref 703.7747866791864 ns/iter 670.1168206060014 ns/iter 1.05
Micro_2020_12_Dynamic_Ref_Single 3.4522558887164516 ns/iter 3.085201423758279 ns/iter 1.12
Micro_2020_12_Simple_Output_Mask 1083.4800027306921 ns/iter 935.7902964410902 ns/iter 1.16
Micro_2020_12_Simple_Output_Annotations 69338.40119291715 ns/iter 66782.89560807648 ns/iter 1.04
Micro_2020_12_Simple_Output_Annotation_Dropping 1654099.7862232649 ns/iter 1525284.8474944956 ns/iter 1.08
Micro_2020_12_Compile_NonCircular_Shared_Refs 979588.1862745739 ns/iter 950849.2496589567 ns/iter 1.03
Micro_2020_12_Exhaustive_Deep_Numeric 8391.439406489619 ns/iter 7142.321587609318 ns/iter 1.17
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput 44582.574107874105 ns/iter 46331.506821459145 ns/iter 0.96
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput 23708.645690561447 ns/iter 19455.227248773383 ns/iter 1.22
Micro_2020_12_Exhaustive_Deep_Numeric_Fail 153.7158671149723 ns/iter 117.1869519190655 ns/iter 1.31
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput 2784.0300796960837 ns/iter 2505.6187776867337 ns/iter 1.11
Alterschema_Check_Readibility_ISO_Language_Set_3 384743472.499963 ns/iter 345884303.50004274 ns/iter 1.11
Alterschema_Check_Readibility_OMC 87413564.24999936 ns/iter 89742420.1249919 ns/iter 0.97
Alterschema_Check_Readibility_KrakenD 1187989717.000164 ns/iter 1440665587.0000122 ns/iter 0.82
Alterschema_Apply_Readibility_KrakenD 122177244104.99977 ns/iter 142645475663.00006 ns/iter 0.86
Alterschema_Check_Invalid_External_Refs 303604374.9999635 ns/iter 193206375.24998575 ns/iter 1.57

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaScript (linux/llvm)

Details
Benchmark suite Current: 3376400 Previous: e29d693 Ratio
E2E_Evaluator_adaptivecard 123072 ns 109882 ns 1.12
E2E_Evaluator_ansible-meta 547399 ns 539997 ns 1.01
E2E_Evaluator_aws-cdk 151147 ns 146408 ns 1.03
E2E_Evaluator_babelrc 357863 ns 503080 ns 0.71
E2E_Evaluator_cerebrum-criminal-case 2608602 ns 2425353 ns 1.08
E2E_Evaluator_clang-format 271473 ns 333461 ns 0.81
E2E_Evaluator_cmake-presets 22039690 ns 18870880 ns 1.17
E2E_Evaluator_code-climate 538521 ns 518752 ns 1.04
E2E_Evaluator_cql2 1299865 ns 1052648 ns 1.23
E2E_Evaluator_cspell 1540917 ns 1770867 ns 0.87
E2E_Evaluator_cypress 790060 ns 1076981 ns 0.73
E2E_Evaluator_deno 1077617 ns 1118576 ns 0.96
E2E_Evaluator_dependabot 1148018 ns 1090766 ns 1.05
E2E_Evaluator_draft-04 23429183 ns 20683562 ns 1.13
E2E_Evaluator_fabric-mod 2390141 ns 2381930 ns 1.00
E2E_Evaluator_geojson 24517403 ns 29473662 ns 0.83
E2E_Evaluator_gitpod-configuration 739147 ns 811247 ns 0.91
E2E_Evaluator_helm-chart-lock 1000631 ns 1036076 ns 0.97
E2E_Evaluator_importmap 261963 ns 315579 ns 0.83
E2E_Evaluator_jasmine 292085 ns 319323 ns 0.91
E2E_Evaluator_jsconfig 1300004 ns 1725049 ns 0.75
E2E_Evaluator_jshintrc 2833949 ns 3154741 ns 0.90
E2E_Evaluator_krakend 682663 ns 574606 ns 1.19
E2E_Evaluator_lazygit 527603 ns 471705 ns 1.12
E2E_Evaluator_lerna 476377 ns 477365 ns 1.00
E2E_Evaluator_nest-cli 619548 ns 718696 ns 0.86
E2E_Evaluator_omc 117051 ns 107002 ns 1.09
E2E_Evaluator_omnisharp 1516093 ns 1537166 ns 0.99
E2E_Evaluator_openapi 47156114 ns 37874749 ns 1.25
E2E_Evaluator_pre-commit-hooks 2046489 ns 2066424 ns 0.99
E2E_Evaluator_pulumi 2148234 ns 2132215 ns 1.01
E2E_Evaluator_semantic-release 270820 ns 289034 ns 0.94
E2E_Evaluator_stale 408643 ns 433067 ns 0.94
E2E_Evaluator_stylecop 1252900 ns 1257042 ns 1.00
E2E_Evaluator_tmuxinator 239223 ns 319741 ns 0.75
E2E_Evaluator_ui5 2309399 ns 1989996 ns 1.16
E2E_Evaluator_ui5-manifest 15699687 ns 10417818 ns 1.51
E2E_Evaluator_unreal-engine-uproject 1665287 ns 1754283 ns 0.95
E2E_Evaluator_users-array 4415472 ns 2864194 ns 1.54
E2E_Evaluator_vercel 1029361 ns 1111222 ns 0.93
E2E_Evaluator_yamllint 26264 ns 25858 ns 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: 3376400 Previous: e29d693 Ratio
Alterschema_Check_Readibility_ISO_Language_Set_3 333175736.5000385 ns/iter 379270543.9999509 ns/iter 0.88
Alterschema_Check_Readibility_OMC 101540667.4285454 ns/iter 102596707.71428578 ns/iter 0.99
Alterschema_Check_Readibility_KrakenD 1418136805.9998932 ns/iter 1388703997.9999826 ns/iter 1.02
Alterschema_Apply_Readibility_KrakenD 136338585340.99977 ns/iter 129231602762.99995 ns/iter 1.05
Alterschema_Check_Invalid_External_Refs 289186039.0000147 ns/iter 324156890.00004023 ns/iter 0.89
Micro_2020_12_Dynamic_Ref 790.7312632244895 ns/iter 798.9040752365175 ns/iter 0.99
Micro_2020_12_Dynamic_Ref_Single 4.572717620220293 ns/iter 4.364067604456619 ns/iter 1.05
Micro_2020_12_Simple_Output_Mask 1070.8943165467942 ns/iter 1102.2225423685777 ns/iter 0.97
Micro_2020_12_Simple_Output_Annotations 74156.23900928795 ns/iter 84542.50669034563 ns/iter 0.88
Micro_2020_12_Simple_Output_Annotation_Dropping 1877562.1367292516 ns/iter 1974244.0450704955 ns/iter 0.95
Micro_2020_12_Compile_NonCircular_Shared_Refs 1069685.6045800648 ns/iter 1109648.9285714524 ns/iter 0.96
Micro_2020_12_Exhaustive_Deep_Numeric 8876.239218805202 ns/iter 8982.89679282428 ns/iter 0.99
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput 53946.60458890171 ns/iter 54657.270289979686 ns/iter 0.99
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput 26710.546616116506 ns/iter 25106.535252265527 ns/iter 1.06
Micro_2020_12_Exhaustive_Deep_Numeric_Fail 176.05454540854674 ns/iter 155.77630292073664 ns/iter 1.13
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput 2990.2481409252932 ns/iter 3323.9172668518877 ns/iter 0.90
Micro_2019_09_Unevaluated_Properties 30.655305844837795 ns/iter 31.17627124788831 ns/iter 0.98
Micro_2019_09_Compile_Wrap 295931399.9999722 ns/iter 330936236.99994624 ns/iter 0.89
Micro_Draft7_If_Then_Else 25.313501367554025 ns/iter 24.92277076401978 ns/iter 1.02
Micro_Draft6_Property_Names 151.35835725287728 ns/iter 142.54964274162077 ns/iter 1.06
Micro_Draft6_Compile_FHIR 14641894249.99995 ns/iter 15348546263.999878 ns/iter 0.95
Micro_Draft4_Meta_1_No_Callback 181.092474946711 ns/iter 185.6015055255873 ns/iter 0.98
Micro_Draft4_Required_Properties 907.1169138291372 ns/iter 887.8937050110723 ns/iter 1.02
Micro_Draft4_Many_Optional_Properties_Minimal_Match 22.03546948355164 ns/iter 22.45443788188931 ns/iter 0.98
Micro_Draft4_Few_Optional_Properties_Minimal_Match 15.846163053637996 ns/iter 16.532968116719562 ns/iter 0.96
Micro_Draft4_Items_Schema 332.8679224695924 ns/iter 337.49677220011347 ns/iter 0.99
Micro_Draft4_Nested_Object 2.1102552575949036 ns/iter 1.879099471041785 ns/iter 1.12
Micro_Draft4_Properties_Triad_Optional 400.4714589273305 ns/iter 432.23597001500485 ns/iter 0.93
Micro_Draft4_Properties_Triad_Closed 326.7949585780796 ns/iter 357.9285783595803 ns/iter 0.91
Micro_Draft4_Properties_Triad_Required 480.75179327490406 ns/iter 491.73704457228257 ns/iter 0.98
Micro_Draft4_Properties_Closed 65.05132629234363 ns/iter 66.23617507141412 ns/iter 0.98
Micro_Draft4_Non_Recursive_Ref 8.807122191456504 ns/iter 9.359874347889392 ns/iter 0.94
Micro_Draft4_Pattern_Properties_True 190.36167513104317 ns/iter 204.43098071742938 ns/iter 0.93
Micro_Draft4_Ref_To_Single_Property 15.839736121486178 ns/iter 17.14794529360104 ns/iter 0.92
Micro_Draft4_Additional_Properties_Type 14.870650816485826 ns/iter 14.322430855616052 ns/iter 1.04
Micro_Draft4_Nested_Oneof 63.369142911605124 ns/iter 65.41532872614343 ns/iter 0.97
Micro_Draft4_Short_Enum 14.543088369287256 ns/iter 14.659306098803597 ns/iter 0.99
Micro_Draft4_Long_Enum 13.11944693326632 ns/iter 12.509547985937088 ns/iter 1.05
Micro_Draft4_Long_Enum_Short_Strings 14.51346949954083 ns/iter 14.771916835319242 ns/iter 0.98
Micro_Draft4_Type_Object 4.5699027231952405 ns/iter 4.669739538109714 ns/iter 0.98
Micro_Draft4_Ref_Single_100 2434162.430555078 ns/iter 2496409.3096080553 ns/iter 0.98
Micro_Draft4_Compile_Ref_Many_Nested 1817246.6580309432 ns/iter 1819974.992228091 ns/iter 1.00
Micro_Draft4_Compile_Wrap 2612296.360594886 ns/iter 2610266.773234423 ns/iter 1.00
JSONLD_Catalog 24547335.42856502 ns/iter 29524109.333332643 ns/iter 0.83
E2E_Compiler_adaptivecard 60123148.41666466 ns/iter 67073895.40001713 ns/iter 0.90
E2E_Compiler_ansible_meta 27909283.560002223 ns/iter 28645696.559997305 ns/iter 0.97
E2E_Compiler_aws_cdk 349279.9717682326 ns/iter 375725.1043897935 ns/iter 0.93
E2E_Compiler_babelrc 2517577.683453029 ns/iter 2544242.4202902075 ns/iter 0.99
E2E_Compiler_clang_format 17518434.900000557 ns/iter 17906218.435900185 ns/iter 0.98
E2E_Compiler_cmake_presets 27140683.115380153 ns/iter 27951240.43999749 ns/iter 0.97
E2E_Compiler_code_climate 2540245.3527269904 ns/iter 2565834.7179488195 ns/iter 0.99
E2E_Compiler_cql2 14131845.459996838 ns/iter 14695084.770835364 ns/iter 0.96
E2E_Compiler_cspell 24060027.344830815 ns/iter 24961531.8928623 ns/iter 0.96
E2E_Compiler_cypress 4154539.624999015 ns/iter 4139565.2559523503 ns/iter 1.00
E2E_Compiler_deno 7787982.444445636 ns/iter 7908925.112357966 ns/iter 0.98
E2E_Compiler_dependabot 3830850.4207649454 ns/iter 3852890.7417585384 ns/iter 0.99
E2E_Compiler_draft_04 2701580.8664119844 ns/iter 2746819.9764709924 ns/iter 0.98
E2E_Compiler_fabric_mod 4619881.236842024 ns/iter 4754970.006802781 ns/iter 0.97
E2E_Compiler_geojson 22313261.774196424 ns/iter 24342311.321431357 ns/iter 0.92
E2E_Compiler_gitpod_configuration 4927516.257352822 ns/iter 5008978.07857135 ns/iter 0.98
E2E_Compiler_helm_chart_lock 631187.1387385697 ns/iter 673899.6260869256 ns/iter 0.94
E2E_Compiler_importmap 251208.7506270361 ns/iter 277591.9797217389 ns/iter 0.90
E2E_Compiler_jasmine 1309165.617977441 ns/iter 1350527.387282905 ns/iter 0.97
E2E_Compiler_jshintrc 4048414.796512208 ns/iter 4204334.024241303 ns/iter 0.96
E2E_Compiler_jsconfig 21381106.393936068 ns/iter 21838926.878782526 ns/iter 0.98
E2E_Compiler_krakend 137818975.4000232 ns/iter 158289994.40000188 ns/iter 0.87
E2E_Compiler_lazygit 32816941.95237876 ns/iter 33670126.90000592 ns/iter 0.97
E2E_Compiler_lerna 1546256.2323008028 ns/iter 1583507.5972848358 ns/iter 0.98
E2E_Compiler_nest_cli 7247443.4845361505 ns/iter 7397149.864582767 ns/iter 0.98
E2E_Compiler_omc 161177589.2499736 ns/iter 184803177.49998677 ns/iter 0.87
E2E_Compiler_omnisharp 6447529.1296288455 ns/iter 6484784.851851247 ns/iter 0.99
E2E_Compiler_openapi 25453211.518517356 ns/iter 26103826.296295866 ns/iter 0.98
E2E_Compiler_pre_commit_hooks 5076170.847826398 ns/iter 5144183.38235266 ns/iter 0.99
E2E_Compiler_pulumi 3942718.9830500237 ns/iter 3979232.3522724677 ns/iter 0.99
E2E_Compiler_semantic_release 1505844.788008977 ns/iter 1539417.5692308436 ns/iter 0.98
E2E_Compiler_stale 1501149.1806450966 ns/iter 1525015.3522973557 ns/iter 0.98
E2E_Compiler_stylecop 5705322.065040956 ns/iter 5729857.867768899 ns/iter 1.00
E2E_Compiler_tmuxinator 1844351.6912929777 ns/iter 1893305.1293800115 ns/iter 0.97
E2E_Compiler_ui5 49912581.92857069 ns/iter 52194952.07143154 ns/iter 0.96
E2E_Compiler_ui5_manifest 311967969.0000794 ns/iter 359939452.4999298 ns/iter 0.87
E2E_Compiler_unreal_engine_uproject 4456896.70063666 ns/iter 4481062.615384009 ns/iter 0.99
E2E_Compiler_users_array 869893.0508055292 ns/iter 895055.8160920301 ns/iter 0.97
E2E_Compiler_vercel 12980796.33333297 ns/iter 13100776.518517368 ns/iter 0.99
E2E_Compiler_yamllint 324616.45898610714 ns/iter 348845.362189092 ns/iter 0.93
E2E_Evaluator_adaptivecard 25394.267472048086 ns/iter 25319.418880001955 ns/iter 1.00
E2E_Evaluator_ansible_meta 262504.3965256907 ns/iter 292316.2527105912 ns/iter 0.90
E2E_Evaluator_aws_cdk 56216.551204567586 ns/iter 63866.11851452189 ns/iter 0.88
E2E_Evaluator_babelrc 97447.24186371293 ns/iter 118411.65370294308 ns/iter 0.82
E2E_Evaluator_cerebrum_criminal_case 1200238.27551041 ns/iter 1155048.3233334792 ns/iter 1.04
E2E_Evaluator_clang_format 101420.76191871637 ns/iter 109711.86189576254 ns/iter 0.92
E2E_Evaluator_cmake_presets 4915630.479167198 ns/iter 6235932.878048627 ns/iter 0.79
E2E_Evaluator_code_climate 201484.49511218478 ns/iter 234764.3714380935 ns/iter 0.86
E2E_Evaluator_cql2 212242.36227906676 ns/iter 234473.55196539205 ns/iter 0.91
E2E_Evaluator_cspell 575465.6534653574 ns/iter 618802.6140667787 ns/iter 0.93
E2E_Evaluator_cypress 155650.2433874449 ns/iter 191339.31533008203 ns/iter 0.81
E2E_Evaluator_deno 326725.82863746333 ns/iter 366670.19490641716 ns/iter 0.89
E2E_Evaluator_dependabot 366446.63028714806 ns/iter 387299.3916435175 ns/iter 0.95
E2E_Evaluator_draft_04 7313627.344085953 ns/iter 11118632.873015644 ns/iter 0.66
E2E_Evaluator_fabric_mod 759128.0599998148 ns/iter 822920.6201642851 ns/iter 0.92
E2E_Evaluator_geojson 18716694.605263673 ns/iter 18549733.052635163 ns/iter 1.01
E2E_Evaluator_gitpod_configuration 241778.99415403465 ns/iter 271811.0666667459 ns/iter 0.89
E2E_Evaluator_helm_chart_lock 225627.46680012034 ns/iter 329975.25933020527 ns/iter 0.68
E2E_Evaluator_importmap 41591.73011244333 ns/iter 51371.10218821114 ns/iter 0.81
E2E_Evaluator_jasmine 114303.42864100766 ns/iter 128406.76706389434 ns/iter 0.89
E2E_Evaluator_jshintrc 1053294.1385084735 ns/iter 1094360.3716953462 ns/iter 0.96
E2E_Evaluator_jsconfig 407538.67732558865 ns/iter 466580.44668008434 ns/iter 0.87
E2E_Evaluator_krakend 193900.39347948137 ns/iter 226809.7461440098 ns/iter 0.85
E2E_Evaluator_lazygit 135659.25592055096 ns/iter 147910.41034336467 ns/iter 0.92
E2E_Evaluator_lerna 139074.09423875215 ns/iter 171004.41693330344 ns/iter 0.81
E2E_Evaluator_nest_cli 194346.91193574286 ns/iter 210208.9076969421 ns/iter 0.92
E2E_Evaluator_omc 22083.789978712404 ns/iter 23596.39834971587 ns/iter 0.94
E2E_Evaluator_omnisharp 548776.0301586301 ns/iter 585147.0008425013 ns/iter 0.94
E2E_Evaluator_openapi 15609441.599998618 ns/iter 18340473.842104793 ns/iter 0.85
E2E_Evaluator_pre_commit_hooks 494800.4799708884 ns/iter 553511.0166140514 ns/iter 0.89
E2E_Evaluator_pulumi 779896.139977447 ns/iter 785912.4791429729 ns/iter 0.99
E2E_Evaluator_semantic_release 91712.31864406983 ns/iter 108403.01823802033 ns/iter 0.85
E2E_Evaluator_stale 175814.38178959733 ns/iter 177408.5655716373 ns/iter 0.99
E2E_Evaluator_stylecop 306455.0239893463 ns/iter 327789.2008309973 ns/iter 0.93
E2E_Evaluator_tmuxinator 97524.15450644224 ns/iter 111239.80860559303 ns/iter 0.88
E2E_Evaluator_ui5 564879.0984412608 ns/iter 615176.6127319748 ns/iter 0.92
E2E_Evaluator_ui5_manifest 2907799.394957509 ns/iter 4067510.9095750586 ns/iter 0.71
E2E_Evaluator_unreal_engine_uproject 464372.11192540603 ns/iter 502189.830999896 ns/iter 0.92
E2E_Evaluator_users_array 716531.9541749723 ns/iter 671609.2453748295 ns/iter 1.07
E2E_Evaluator_vercel 283798.87025059207 ns/iter 344756.92561585305 ns/iter 0.82
E2E_Evaluator_yamllint 11945.718734577153 ns/iter 13293.547319409543 ns/iter 0.90
Schema_Format_ISO_Language_To_JSON 106610961.42848691 ns/iter 119974962.6667123 ns/iter 0.89
Schema_Bundle_Meta_2020_12 1697230.8913048126 ns/iter 1765966.1284608406 ns/iter 0.96
Schema_Frame_WoT_References 5157924.294118576 ns/iter 5241510.9925372675 ns/iter 0.98
Schema_Frame_OMC_References 22214658.483870797 ns/iter 24754681.655175425 ns/iter 0.90
Schema_Frame_OMC_Locations 20607343.64705668 ns/iter 22510952.096772306 ns/iter 0.92
Schema_Frame_ISO_Language_Locations 99896371.57140611 ns/iter 113271156.99998558 ns/iter 0.88
Schema_Frame_KrakenD_References 40266828.176473774 ns/iter 45194673.60000817 ns/iter 0.89
Schema_Frame_KrakenD_Reachable 565469135.0000576 ns/iter 696996398.0002376 ns/iter 0.81
Schema_Frame_ISO_Language_Locations_To_JSON 180070650.49999937 ns/iter 190520763.9999844 ns/iter 0.95
Schema_Frame_Many_Resources_References 371081146.4999324 ns/iter 408540974.0000614 ns/iter 0.91
Schema_Iterator_ISO_Language 3683407.820106021 ns/iter 4087553.0000004782 ns/iter 0.90
Schema_Tracker_ISO_Language 5134417.321167441 ns/iter 5849710.567797386 ns/iter 0.88
Schema_Tracker_ISO_Language_To_JSON 25984081.4074121 ns/iter 29309467.083332192 ns/iter 0.89

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaScript (linux/gcc)

Details
Benchmark suite Current: 3376400 Previous: e29d693 Ratio
E2E_Evaluator_adaptivecard 118282 ns 124736 ns 0.95
E2E_Evaluator_ansible-meta 547967 ns 547678 ns 1.00
E2E_Evaluator_aws-cdk 126958 ns 141612 ns 0.90
E2E_Evaluator_babelrc 343236 ns 364606 ns 0.94
E2E_Evaluator_cerebrum-criminal-case 2606712 ns 2821413 ns 0.92
E2E_Evaluator_clang-format 252493 ns 266996 ns 0.95
E2E_Evaluator_cmake-presets 16907825 ns 19191544 ns 0.88
E2E_Evaluator_code-climate 489233 ns 514789 ns 0.95
E2E_Evaluator_cql2 1245648 ns 1225346 ns 1.02
E2E_Evaluator_cspell 1573179 ns 1672933 ns 0.94
E2E_Evaluator_cypress 803878 ns 810972 ns 0.99
E2E_Evaluator_deno 1046310 ns 1082182 ns 0.97
E2E_Evaluator_dependabot 1063719 ns 1136490 ns 0.94
E2E_Evaluator_draft-04 19931940 ns 23588081 ns 0.85
E2E_Evaluator_fabric-mod 2319259 ns 2450120 ns 0.95
E2E_Evaluator_geojson 24136057 ns 25791882 ns 0.94
E2E_Evaluator_gitpod-configuration 713880 ns 725651 ns 0.98
E2E_Evaluator_helm-chart-lock 999459 ns 1000759 ns 1.00
E2E_Evaluator_importmap 260412 ns 275269 ns 0.95
E2E_Evaluator_jasmine 279551 ns 301435 ns 0.93
E2E_Evaluator_jsconfig 1365064 ns 1256142 ns 1.09
E2E_Evaluator_jshintrc 2880715 ns 2830254 ns 1.02
E2E_Evaluator_krakend 640770 ns 695314 ns 0.92
E2E_Evaluator_lazygit 440461 ns 535452 ns 0.82
E2E_Evaluator_lerna 432463 ns 474080 ns 0.91
E2E_Evaluator_nest-cli 593748 ns 617728 ns 0.96
E2E_Evaluator_omc 115209 ns 117934 ns 0.98
E2E_Evaluator_omnisharp 1460770 ns 1480990 ns 0.99
E2E_Evaluator_openapi 39801961 ns 44779948 ns 0.89
E2E_Evaluator_pre-commit-hooks 1913173 ns 2031923 ns 0.94
E2E_Evaluator_pulumi 1929484 ns 1972674 ns 0.98
E2E_Evaluator_semantic-release 225567 ns 268855 ns 0.84
E2E_Evaluator_stale 370835 ns 425715 ns 0.87
E2E_Evaluator_stylecop 1174553 ns 1257232 ns 0.93
E2E_Evaluator_tmuxinator 214492 ns 233774 ns 0.92
E2E_Evaluator_ui5 2156850 ns 2231751 ns 0.97
E2E_Evaluator_ui5-manifest 9849034 ns 14651838 ns 0.67
E2E_Evaluator_unreal-engine-uproject 1566861 ns 1581809 ns 0.99
E2E_Evaluator_users-array 2856311 ns 3420231 ns 0.84
E2E_Evaluator_vercel 985838 ns 1014717 ns 0.97
E2E_Evaluator_yamllint 23471 ns 26068 ns 0.90

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti
jviotti force-pushed the fix-logical-condition-inline-cursors branch 5 times, most recently from f89e8be to 103cd2e Compare July 17, 2026 16:11
@jviotti jviotti changed the title Fix LogicalCondition bug on fast mode with annotation whitelists [WIP] Do a correctness pass on the compiler + tests Jul 17, 2026
@jviotti jviotti changed the title [WIP] Do a correctness pass on the compiler + tests [WIP] Add several tests for edge cases on the compiler/evaluator Jul 17, 2026
@jviotti
jviotti force-pushed the fix-logical-condition-inline-cursors branch 12 times, most recently from 04ef373 to 313c161 Compare July 18, 2026 21:29
@jviotti
jviotti force-pushed the fix-logical-condition-inline-cursors branch 2 times, most recently from 680bc27 to 1492363 Compare July 18, 2026 23:11
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti force-pushed the fix-logical-condition-inline-cursors branch from 1492363 to 3376400 Compare July 19, 2026 00:35
@jviotti jviotti changed the title [WIP] Add several tests for edge cases on the compiler/evaluator Roll back fast-mode evaluation marks from failed conditionals Jul 19, 2026
@jviotti

jviotti commented Jul 19, 2026

Copy link
Copy Markdown
Member Author

augment review

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread ports/javascript/index.mjs
@jviotti
jviotti merged commit fa575e5 into main Jul 19, 2026
14 checks passed
@jviotti
jviotti deleted the fix-logical-condition-inline-cursors branch July 19, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant